Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[demo] Fix downgrade webpack to fix demo app, known issue in latest #647

Merged
merged 3 commits into from
Dec 1, 2020
Merged

[demo] Fix downgrade webpack to fix demo app, known issue in latest #647

merged 3 commits into from
Dec 1, 2020

Conversation

dtassone
Copy link
Member

Just a small fix to make sure we can still test pkgs in the demo app...

@oliviertassinari
Copy link
Member

What's the difference?

@dtassone
Copy link
Member Author

What's the difference?

the old pkg work, and the new one does not.
webpack/webpack-dev-server#2029 (comment)

@oliviertassinari
Copy link
Member

Thanks for the reference. The sooner we can do #632, the better :)

@dtassone dtassone merged commit 32121c0 into mui:master Dec 1, 2020
@dtassone dtassone changed the title Fix downgrade webpack to fix demo app, known issue in latest [Demo] Fix downgrade webpack to fix demo app, known issue in latest Dec 1, 2020
@oliviertassinari oliviertassinari changed the title [Demo] Fix downgrade webpack to fix demo app, known issue in latest [demo] Fix downgrade webpack to fix demo app, known issue in latest Dec 1, 2020
@oliviertassinari oliviertassinari added the docs Improvements or additions to the documentation label Dec 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanailH DanailH DanailH approved these changes

Assignees

@dtassone dtassone

Labels
docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dtassone @oliviertassinari @DanailH