Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add support for optimizeFor isoline parameters #119

Closed
hrecht opened this issue Mar 10, 2021 · 2 comments · Fixed by #126
Closed

Feature: Add support for optimizeFor isoline parameters #119

hrecht opened this issue Mar 10, 2021 · 2 comments · Fixed by #126
Assignees
Labels
feature New feature or enhancement

Comments

@hrecht
Copy link

hrecht commented Mar 10, 2021

Description
It would be very helpful if the isoline function supported all of the API parameters, including optimizeFor.

Or if that can already be used, how do we include it? Thanks for this great package!

@hrecht hrecht added the feature New feature or enhancement label Mar 10, 2021
@munterfi munterfi self-assigned this Mar 10, 2021
munterfi added a commit that referenced this issue Mar 10, 2021
@munterfi
Copy link
Owner

munterfi commented Mar 10, 2021

Hi, thanks for reporting and the positive feedback on the package.

Can you test with remotes::install_github("munterfinger/hereR@feature/isoline-optimize")?

q <- isoline(..., optimize = "quality")
p <- isoline(..., optimize = "performance")
b <- isoline(..., optimize = "balanced")

@hrecht
Copy link
Author

hrecht commented Mar 10, 2021

This seems to be working. Thank you!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants