fix(core): Fix resuming executions on test webhooks from Wait nodes #13168
+28
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
n8n-assistant
bot
added
core
tomi
previously approved these changes
Feb 10, 2025
| @@ -121,6 +121,8 @@ export class WaitingWebhooks implements IWebhookManager { | |||
|
|
|||
| const lastNodeExecuted = execution.data.resultData.lastNodeExecuted as string; | |||
|
|
|||
| if (execution.mode === 'manual') execution.data.isTestWebhook = true; | |||
There was a problem hiding this comment.
Maybe we could add a comment here why we are setting this for future reference
n8n
|
||||||||||||||||||||||||||||
| Project |
n8n
|
| Branch Review |
cat-604
|
| Run status |
|
| Run duration | 04m 41s |
| Commit |
|
| Committer | Iván Ovejero |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
1
|
Pending
|
5
|
Skipped
|
0
|
Passing
|
435
|
| View all changes introduced in this branch ↗︎ | |
|
✅ All Cypress E2E specs passed |
tomi
approved these changes
Feb 10, 2025
|
|
|
✅ All Cypress E2E specs passed |
Merged
|
Got released with |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
On master, in scaling mode, on both single- or multi-main, if you put an execution to wait for a webhook call and then call the webhook to resume the execution, the worker runs the execution from the start instead of resuming from the wait node. This PR ensures that workers resume the execution instead of restarting it.
To reproduce, import this workflow https://n8n.to/cat-604 and run it and call
curl -X POST http://localhost:5678/webhook-waiting/{n}(find thenfrom the Wait node on the UI). Before this fix, worker logs show all nodes being executed; after this fix, worker logs show only the Wait node being executed. Tested withOFFLOAD_MANUAL_EXECUTIONS_TO_WORKERSenabled and disabled, and in both single- and multi-main mode.Note there is a related but out of scope issue affecting push messages on resuming.
Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/CAT-604
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)