feat(n8n Form Node): Warnings update #13523
Open
+246
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-radency
added
node/improvement
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Tested locally
- triggerNotice works 👌
- completionPageNotice only shows in queue mode, but it's shown always not sure if we can remove it in cases when completion form page is linked
- copy needs tweaking I will add a comment with that later
- locally in queue mode I was getting errors with waiting but shouldn't be related to this fix
could you please add tests for these changes 🙏
…form-update-redirection-logic-warnings
though should be possible, it would be computational intensive and most likely adds noticeable lag |
…form-update-redirection-logic-warnings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
show
'An n8n Form Trigger node must be set up before this node'warning only if no Form trigger connectedshow
'Add Form node with 'Form Ending' page type to the end of each branch in your workflow'warning if Form is connected to Form trigger, page type is not Form Ending, and Queue mode is enabledRelated Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/NODE-2352/form-update-redirection-logic
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)