chore: Add unit tests for findTriggerForPartialExecution
#13541
+193
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
netroy
commented
Feb 26, 2025
Comment on lines
+63
to
+65
| // Prioritize webhook triggers over other parent triggers | ||
| const webhookTriggers = parentTriggers.filter((trigger) => trigger.type.endsWith('webhook')); | ||
| return webhookTriggers.length > 0 ? webhookTriggers[0] : parentTriggers[0]; |
There was a problem hiding this comment.
not sure about this bit. I vaguely remember something along these lines from a couple of years ago, but can't find any discussions.
Let me know if you prefer to revert these lines, and delete the tests covering this.
n8n-assistant
bot
added
core
…erForPartialExecution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related Linear tickets, Github issues, and Community forum posts
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)