Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Postgres Node): Accommodate null values in query parameters for expressions #13544

Conversation

dana-gill
Copy link
Contributor

Summary

Accommodate null values in query parameters for expressions. This was broken after #12452 because null and undefined values were treated the same when they should be treated differently.

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/NODE-2448/postgres-node-null-values-in-the-string-of-query-parameters-ignored

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@dana-gill dana-gill requested a review from elsmr February 26, 2025 19:29
@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team node/improvement New feature or request labels Feb 26, 2025
Copy link

codecov bot commented Feb 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

Copy link

cypress bot commented Feb 27, 2025

n8n    Run #9543

Run Properties:  status check failed Failed #9543  •  git commit 916a56b157: 🌳 cat-680-cypress-screen-width-changes 🖥️ browsers:node18.12.0-chrome107 🤖 sh...
Project n8n
Branch Review cat-680-cypress-screen-width-changes
Run status status check failed Failed #9543
Run duration 04m 29s
Commit git commit 916a56b157: 🌳 cat-680-cypress-screen-width-changes 🖥️ browsers:node18.12.0-chrome107 🤖 sh...
Committer Declan Carroll
View all properties for this run ↗︎

Test results
Tests that failed  Failures 3
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 1
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 295
View all changes introduced in this branch ↗︎

Tests for review

Failed  12-canvas.cy.ts • 1 failed test

View Output Video

Test Artifacts
Canvas Node Manipulation and Navigation > Canvas Zoom Functionality > should zoom to fit Screenshots Video
Failed  20-workflow-executions.cy.ts • 2 failed tests

View Output Video

Test Artifacts
Workflow Executions > when workflow is saved > should render executions tab correctly Test Replay Screenshots Video
Workflow Executions > when workflow is saved > should load items and auto scroll after filter change Test Replay Screenshots Video
Failed  21-community-nodes.cy.ts • 0 failed tests

View Output

Test Artifacts
Failed  19-execution.cy.ts • 0 failed tests

View Output

Test Artifacts
Failed  26-resource-locator.cy.ts • 0 failed tests

View Output

Test Artifacts

The first 5 failed specs are shown, see all 42 specs in Cypress Cloud.

Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

Copy link
Contributor

✅ All Cypress E2E specs passed

@elsmr elsmr added the release/backport Changes that need to be backported to older releases. label Feb 27, 2025
@elsmr elsmr merged commit 6c266ac into master Feb 27, 2025
38 checks passed
@elsmr elsmr deleted the node-2448-postgres-node-null-values-in-the-string-of-query-parameters branch February 27, 2025 15:39
@github-actions github-actions bot mentioned this pull request Feb 28, 2025
@github-actions github-actions bot mentioned this pull request Feb 28, 2025
@janober
Copy link
Member

janober commented Feb 28, 2025

Got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team node/improvement New feature or request release/backport Changes that need to be backported to older releases. Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants