Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(json-schema-to-zod): remove postesm and postcjs #13546

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gigamaax
Copy link

haivng a nested package.json causes issues with vitest resolving the correct files. the root level package.json already uses the module, main, and export fields.

Summary

when using vitest, it would throw an error saying the package couldn't be resolved.
Screenshot 2025-02-26 at 12 23 05 PM

I was able to track this down to the nested package.json inside the esm and cjs folders. remove those allowed vitest to resolve properly.

Related Linear tickets, Github issues, and Community forum posts

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

haivng a nested package.json causes issues with vitest resolving the
correct files. the root level package.json already uses the module,
main, and export fields.
@CLAassistant
Copy link

CLAassistant commented Feb 26, 2025

CLA assistant check
All committers have signed the CLA.

@n8n-assistant n8n-assistant bot added community Authored by a community member in linear Issue or PR has been created in Linear for internal review labels Feb 26, 2025
@Joffcom
Copy link
Member

Joffcom commented Feb 26, 2025

Hey @gigamaax,

Thanks for the PR, We have created "GHC-976" as the internal reference to get this reviewed.

One of us will be in touch if there are any changes needed, in most cases this is normally within a couple of weeks but it depends on the current workload of the team.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Authored by a community member in linear Issue or PR has been created in Linear for internal review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants