fix(core): Do not validate email when LDAP is enabled #13605
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Understanding the Issue
The core problem stems from a previous PR (#12375) where we started validating the email via the DTO. This created an unexpected issue for LDAP users because the "email" field might not actually contain an email address but rather a username based on LDAP configuration. The validation was rejecting non-email formats, preventing legitimate LDAP users from logging in.
Solution Approach
I note that a better long-term solution would be to separate authentication flows between administrators and LDAP members, but this larger refactoring is out of scope for this immediate fix.
Affected Users
This affects instances on
[email protected]
and later where LDAP is configured to use a non-email identifier (anything other than "mail").Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/CAT-672/community-issue-ldap-users-wrong-email-validation
#13462
Review / Merge checklist
release/backport
(if the PR is an urgent fix that needs to be backported)