Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix alias type value conversion & cycles #631

Merged
merged 5 commits into from
Feb 27, 2025
Merged

Fix alias type value conversion & cycles #631

merged 5 commits into from
Feb 27, 2025

Conversation

Kronos3
Copy link
Collaborator

@Kronos3 Kronos3 commented Feb 26, 2025 •
edited
Loading

This fixes two bugs:

@Kronos3 Kronos3 requested a review from bocchino February 26, 2025 17:17
bocchino
bocchino requested changes Feb 26, 2025
View reviewed changes
Copy link
Collaborator

@bocchino bocchino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just a couple of comments to address.

@bocchino bocchino mentioned this pull request Feb 26, 2025
Draft
bocchino
bocchino approved these changes Feb 27, 2025
View reviewed changes
Copy link
Collaborator

@bocchino bocchino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@bocchino bocchino merged commit 7c2e2f1 into main Feb 27, 2025
11 checks passed
@bocchino bocchino deleted the tumbar-type-alias-value branch February 27, 2025 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bocchino bocchino bocchino approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error received when creating an array with alias type
2 participants
@Kronos3 @bocchino