Cat metadata #38
Merged
Cat metadata #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
collinss-jpl
force-pushed
the
cat-metadata
branch
from
47c5638 to
64a3b8f
Compare
collinss-jpl
requested changes
Jan 19, 2022
There was a problem hiding this comment.
Overall this branch is moving in the right direction, but there are a number of improvements I think could be made.
Also FYI, I rebased this branch to incorporate the addition of the build/test pipeline for pull requests in Jenkins. If you log into our Jenkins CI server you should now see pipelines run for this branch/PR. We can cover this more in our next tag-up. Great work so far, keep it up!
collinss-jpl
requested changes
Jan 24, 2022
…aned up docstrings.
collinss-jpl
approved these changes
Jan 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basic functionality and unit tests in place.