DSWx-HLS SAS Beta Integration #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
April 4, 2022 13:10
PGE now expects output file name info to be contained by the SAS portion of the config
…e not properly filtered out
…t tif files, and include it with the file-naming conventions.
…beta DSWx SAS delivery
JimHofman
approved these changes
Apr 21, 2022
| @@ -187,7 +187,7 @@ def __getattribute__(self, item): | |||
| except KeyError as error: | |||
| # TODO: create exceptions package with more intuitive exception class names | |||
| raise RuntimeError( | |||
| f'Expected field "{str(error)}" is missing from RunConfig ' | |||
| f'Expected field {str(error)} is missing from RunConfig ' | |||
There was a problem hiding this comment.
Opinion: Having the keyword error in quotes highlights the error. Sometimes messages and blend into the text and take a second look to read clearly.
| @@ -338,15 +333,19 @@ def get_input_filenames(self): | |||
|
|
|||
| input_files = [] | |||
|
|
|||
| def __is_input_file(filename): | |||
There was a problem hiding this comment.
Is there a reason to use '__' rather than '_' to identify the method as internal? Just wondering for future use?
There was a problem hiding this comment.
|
Minimal comments. Looks good. Nice job Scott. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the necessary changes for the current DSWx-HLS PGE code to accommodate the new SAS beta delivery image. Changes include: