Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add attribute check #1311

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add attribute check #1311

wants to merge 3 commits into from

Conversation

lrafeei
Copy link
Contributor

@lrafeei lrafeei commented Feb 25, 2025

This PR adds an attribute check for the GC runtime metrics check.

settings.gc_runtime_metrics is of type GCRuntimeMetricsSettings() and this inherits from Settings()
global_settings() uses TopLevelSettings() which also inherits from Settings()

global_settings may not necessarily have access to the gc_runtime_metrics and these instances result in an attribute error for this enable check.

Copy link

github-actions bot commented Feb 25, 2025

🦙 MegaLinter status: ❌ ERROR

Descriptor Linter Files Fixed Errors Elapsed time
❌ PYTHON ruff 1 0 1 0.06s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@lrafeei lrafeei marked this pull request as ready for review February 25, 2025 18:32
@lrafeei lrafeei requested a review from a team as a code owner February 25, 2025 18:32
@codecov-commenter
Copy link

codecov-commenter commented Feb 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.30%. Comparing base (9429694) to head (d18f9b5).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1311      +/-   ##
==========================================
+ Coverage   80.24%   81.30%   +1.05%     
==========================================
  Files         203      203              
  Lines       22499    22501       +2     
  Branches     3560     3561       +1     
==========================================
+ Hits        18054    18294     +240     
+ Misses       3312     3020     -292     
- Partials     1133     1187      +54     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants