nilsbeck/improve-duration-matrix-performance #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merschformann
approved these changes
Oct 24, 2024
factory/validate.go
Outdated
| } | ||
| result = append(result, matrix) | ||
| } else { | ||
| return nil, fmt.Errorf("invalid time-dependent matrix format") |
There was a problem hiding this comment.
Let's be a bit more specific here and add the index of the failing entry (just in case someone ever messes up a different entry than the first one 😅 ).
factory/validate.go
Outdated
| return validateTimeDependentMatricesAndIDs(input, timeDependentMatrices, modelOptions) | ||
| } | ||
|
|
||
| // Converts a single or multiple time-dependent matrices from a slice of interfaces to []schema.TimeDependentMatrix. |
There was a problem hiding this comment.
Can it really deal with a single time-dependent matrix? Or, does that only refer to the slice containing one?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes slow json marshalling to improve performance when reading duration matrix data.