Fixes bug in plateau detection #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merschformann
requested review from
sebastian-quintero,
nmisek and
dirkschumacher
nmisek
approved these changes
Jan 21, 2025
sebastian-quintero
approved these changes
Jan 21, 2025
merschformann
deleted the
feature/eng-5676-fix-bug-in-nextroute-plateau-detection
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a bug in the new plateau detection functionality that caused it to not work correctly when solutions were still found within cutoff.
Changes
cutoffValue-currentValuefor both absolute and relative thresholds to ensure termination criteria are correctly applied.