Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib,src: iterate module requests of a module wrap in JS #52058

Merged
merged 1 commit into from
Apr 25, 2024
Merged

lib,src: iterate module requests of a module wrap in JS #52058

merged 1 commit into from
Apr 25, 2024

Conversation

legendecas
Copy link
Member

@legendecas legendecas commented Mar 12, 2024 •
edited
Loading

Avoid repetitively calling into JS callback from C++ in
ModuleWrap::Link. This removes the convoluted callback style of the
internal ModuleWrap link step.

Refs: #51977 (comment)

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/loaders
  • @nodejs/vm

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Mar 12, 2024
@legendecas legendecas marked this pull request as ready for review March 12, 2024 18:15
@legendecas legendecas force-pushed the module/link branch 2 times, most recently from 26b9280 to b201582 Compare March 12, 2024 18:18
@legendecas legendecas force-pushed the module/link branch 2 times, most recently from c372b99 to 6daec91 Compare March 13, 2024 07:14
@legendecas legendecas requested a review from joyeecheung March 18, 2024 17:06
@legendecas legendecas force-pushed the module/link branch 2 times, most recently from a79c903 to 572d6b0 Compare March 19, 2024 03:02
@legendecas legendecas added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 22, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 22, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57894/

joyeecheung
joyeecheung reviewed Mar 22, 2024
View reviewed changes
@legendecas
Copy link
Member Author

Rebased on top of the tip of the main branch.

@legendecas legendecas added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 14, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 14, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/58381/

@legendecas legendecas added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 15, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 15, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/58413/

joyeecheung
joyeecheung reviewed Apr 16, 2024
View reviewed changes
Copy link
Member

@joyeecheung joyeecheung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General idea LGTM though this needs a rebase

lib/internal/vm/module.js
assert.fail('link callback should not be called');
});
[kLink]() {
/** nothing to do for synthetic modules */
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't need to be solved in this PR but it seems weird that we provide the link method for SyntheticModule at all....

@legendecas
lib,src: iterate module requests of a module wrap in JS
9f615f1 
Avoid repetitively calling into JS callback from C++ in
`ModuleWrap::Link`. This removes the convoluted callback style of the
internal `ModuleWrap` link step.
@legendecas legendecas added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 25, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 25, 2024
@nodejs-github-bot nodejs-github-bot merged commit d5c7ffd into nodejs:main Apr 25, 2024
58 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in d5c7ffd

@legendecas legendecas deleted the module/link branch April 25, 2024 15:49
aduh95 pushed a commit that referenced this pull request Apr 29, 2024
@legendecas @aduh95
lib,src: iterate module requests of a module wrap in JS
9b2b6ab 
Avoid repetitively calling into JS callback from C++ in
`ModuleWrap::Link`. This removes the convoluted callback style of the
internal `ModuleWrap` link step.

PR-URL: #52058
Reviewed-By: Joyee Cheung <[email protected]>
@aduh95 aduh95 mentioned this pull request Apr 30, 2024
Merged
@joyeecheung joyeecheung mentioned this pull request Jun 17, 2024
Closed
joyeecheung pushed a commit to joyeecheung/node that referenced this pull request Jun 18, 2024
@legendecas @joyeecheung
lib,src: iterate module requests of a module wrap in JS
6cc0e5f 
Avoid repetitively calling into JS callback from C++ in
`ModuleWrap::Link`. This removes the convoluted callback style of the
internal `ModuleWrap` link step.

PR-URL: nodejs#52058
Reviewed-By: Joyee Cheung <[email protected]>
bmeck pushed a commit to bmeck/node that referenced this pull request Jun 22, 2024
@legendecas @bmeck
lib,src: iterate module requests of a module wrap in JS
a412115 
Avoid repetitively calling into JS callback from C++ in
`ModuleWrap::Link`. This removes the convoluted callback style of the
internal `ModuleWrap` link step.

PR-URL: nodejs#52058
Reviewed-By: Joyee Cheung <[email protected]>
@marco-ippolito marco-ippolito added the backport-blocked-v20.x PRs that should land on the v20.x-staging branch but are blocked by another PR's pending backport. label Jul 19, 2024
@joyeecheung joyeecheung mentioned this pull request Aug 23, 2024
Closed
@joyeecheung joyeecheung mentioned this pull request Jan 6, 2025
Open
6 tasks
joyeecheung pushed a commit to joyeecheung/node that referenced this pull request Jan 23, 2025
@legendecas @joyeecheung
lib,src: iterate module requests of a module wrap in JS
986d0a1 
Avoid repetitively calling into JS callback from C++ in
`ModuleWrap::Link`. This removes the convoluted callback style of the
internal `ModuleWrap` link step.

PR-URL: nodejs#52058
Reviewed-By: Joyee Cheung <[email protected]>
joyeecheung pushed a commit to joyeecheung/node that referenced this pull request Jan 23, 2025
@legendecas @joyeecheung
lib,src: iterate module requests of a module wrap in JS
33bbaf8 
Avoid repetitively calling into JS callback from C++ in
`ModuleWrap::Link`. This removes the convoluted callback style of the
internal `ModuleWrap` link step.

PR-URL: nodejs#52058
Reviewed-By: Joyee Cheung <[email protected]>
joyeecheung pushed a commit to joyeecheung/node that referenced this pull request Jan 23, 2025
@legendecas @joyeecheung
lib,src: iterate module requests of a module wrap in JS
45cf4cd 
Avoid repetitively calling into JS callback from C++ in
`ModuleWrap::Link`. This removes the convoluted callback style of the
internal `ModuleWrap` link step.

PR-URL: nodejs#52058
Reviewed-By: Joyee Cheung <[email protected]>
joyeecheung pushed a commit to joyeecheung/node that referenced this pull request Jan 23, 2025
@legendecas @joyeecheung
lib,src: iterate module requests of a module wrap in JS
d144032 
Avoid repetitively calling into JS callback from C++ in
`ModuleWrap::Link`. This removes the convoluted callback style of the
internal `ModuleWrap` link step.

PR-URL: nodejs#52058
Reviewed-By: Joyee Cheung <[email protected]>
@joyeecheung joyeecheung mentioned this pull request Jan 23, 2025
Closed
joyeecheung pushed a commit to joyeecheung/node that referenced this pull request Jan 23, 2025
@legendecas @joyeecheung
lib,src: iterate module requests of a module wrap in JS
196a663 
Avoid repetitively calling into JS callback from C++ in
`ModuleWrap::Link`. This removes the convoluted callback style of the
internal `ModuleWrap` link step.

PR-URL: nodejs#52058
Reviewed-By: Joyee Cheung <[email protected]>
joyeecheung pushed a commit to joyeecheung/node that referenced this pull request Jan 31, 2025
@legendecas @joyeecheung
lib,src: iterate module requests of a module wrap in JS
6e1b8b6 
Avoid repetitively calling into JS callback from C++ in
`ModuleWrap::Link`. This removes the convoluted callback style of the
internal `ModuleWrap` link step.

PR-URL: nodejs#52058
Reviewed-By: Joyee Cheung <[email protected]>
joyeecheung pushed a commit to joyeecheung/node that referenced this pull request Feb 5, 2025
@legendecas @joyeecheung
lib,src: iterate module requests of a module wrap in JS
b0a7ded 
Avoid repetitively calling into JS callback from C++ in
`ModuleWrap::Link`. This removes the convoluted callback style of the
internal `ModuleWrap` link step.

PR-URL: nodejs#52058
Reviewed-By: Joyee Cheung <[email protected]>
joyeecheung pushed a commit to joyeecheung/node that referenced this pull request Feb 5, 2025
@legendecas @joyeecheung
lib,src: iterate module requests of a module wrap in JS
946b08e 
Avoid repetitively calling into JS callback from C++ in
`ModuleWrap::Link`. This removes the convoluted callback style of the
internal `ModuleWrap` link step.

PR-URL: nodejs#52058
Reviewed-By: Joyee Cheung <[email protected]>
@joyeecheung joyeecheung added backport-open-v20.x Indicate that the PR has an open backport and removed backport-blocked-v20.x PRs that should land on the v20.x-staging branch but are blocked by another PR's pending backport. labels Feb 6, 2025
@joyeecheung
Copy link
Member

Backport open in #56927

joyeecheung pushed a commit to joyeecheung/node that referenced this pull request Feb 6, 2025
@legendecas @joyeecheung
lib,src: iterate module requests of a module wrap in JS
b3947ac 
Avoid repetitively calling into JS callback from C++ in
`ModuleWrap::Link`. This removes the convoluted callback style of the
internal `ModuleWrap` link step.

PR-URL: nodejs#52058
Reviewed-By: Joyee Cheung <[email protected]>
@joyeecheung joyeecheung mentioned this pull request Feb 7, 2025
Closed
joyeecheung pushed a commit to joyeecheung/node that referenced this pull request Feb 10, 2025
@legendecas @joyeecheung
lib,src: iterate module requests of a module wrap in JS
5477382 
Avoid repetitively calling into JS callback from C++ in
`ModuleWrap::Link`. This removes the convoluted callback style of the
internal `ModuleWrap` link step.

PR-URL: nodejs#52058
Reviewed-By: Joyee Cheung <[email protected]>
marco-ippolito pushed a commit that referenced this pull request Feb 11, 2025
@legendecas @marco-ippolito
lib,src: iterate module requests of a module wrap in JS
f13589f 
Avoid repetitively calling into JS callback from C++ in
`ModuleWrap::Link`. This removes the convoluted callback style of the
internal `ModuleWrap` link step.

PR-URL: #52058
Backport-PR-URL: #56927
Reviewed-By: Joyee Cheung <[email protected]>
Refs: #52697
@marco-ippolito marco-ippolito mentioned this pull request Mar 6, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joyeecheung joyeecheung joyeecheung approved these changes

@devsnek devsnek devsnek left review comments

Assignees
No one assigned
Labels
backport-open-v20.x Indicate that the PR has an open backport c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@legendecas @nodejs-github-bot @joyeecheung @devsnek @marco-ippolito