fix(web): Intercom chat bubble should not show after closing integrat… #4951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ion sidebar
What change does this PR introduce?
The intercom chat bubble used to show up after closing the integration sidebar. The RCA was that on closing the sidebar, it used to update the intercom provider with this data: update({ hideDefaultLauncher: false });
According to the https://www.intercom.com/help/en/articles/189-hide-the-messenger, the official intercom blog mentions : "If you want to hide the Messenger programatically, you can do this by adding the key-value pari hide_default_launcher to true or false in your intercomSettings snippet 👍".
So I removed the above call to update();
Why was this change needed?
This issue closes [NV-3237] (#4912).
Other information (Screenshots)
Screen.Recording.2023-12-06.at.5.07.41.PM.mov