Translation management beta #5124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-with-dnd feat: add dropzone package
❌ Deploy Preview for dev-web-novu failed.
|
Co-authored-by: ainouzgali <[email protected]>
…to-upload-translation-files-tests feat: add file upload support for cypress
…annel-preview-sidebar-and-route
…ew-sidebar-and-route' into nv-3007-create-the-channel-preview-sidebar-and-route
…ew-sidebar-and-route Create the channel preview sidebar and route
…-buttons-preview-for-in-app feat: implement cta and avatar
…-use-default-locale-of-the-organization-as-fallback
…e-organization-as-fallback feat: add fallback lng
…component Nv 2993 reusable in app preview component
…t-beta # Conflicts: # .source # apps/web/src/pages/auth/components/SignUpForm.tsx # apps/web/src/pages/integrations/components/NovuInAppForm.tsx # libs/design-system/src/icons/index.ts
…o nv-3416-variants-preview # Conflicts: # .source
…o nv-3416-variants-preview
feat(web): translation management variants preview
BiswaViraj
reviewed
Feb 26, 2024
| return <>DIGEST</>; | ||
|
|
||
| default: | ||
| return <>dummy</>; |
There was a problem hiding this comment.
@ainouzgali now that we have implemented all the channels preview, we should have some proper UI here,
"Unexpected error occurred!" something like that
There was a problem hiding this comment.
Great points, I will do that after we deploy to dev :) I want Nikolay to be able to start testing
| return <EmailPreview view="web" showVariables={false} />; | ||
|
|
||
| case StepTypeEnum.TRIGGER: | ||
| return <>TRIGGER</>; |
There was a problem hiding this comment.
Maybe we can remove this or update the trigger sidebar to use this component
…-designs Nv 3420 css inconsistencies with designs
LetItRock
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What change does this PR introduce?
Why was this change needed?
Other information (Screenshots)