Editor autocomplete - does not open in a second use #5290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dev-web-novu ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
It seems to not work after adding an empty line in between Screen.Recording.2024-03-11.at.4.35.38.PM.mov |
ainouzgali
deleted the
nv-3403-editor-autocomplete-does-not-open-in-a-second-use
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What change does this PR introduce?
In the editor, after adding a {{..}} once. Writing only one { opens the autocomplete dropdown, when adding the second { (so its {{ ) the dropdown does not show again.
The slice was wrong, at the second input of {{ it took the whole content and so used the indexes of the first {{
Why was this change needed?
Other information (Screenshots)