feat(api): Allow img tags in the In-App & Email Editor #5312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy request for dev-web-novu pending review.Visit the deploys page to approve it
|
scopsy
approved these changes
Mar 18, 2024
|
@efaraz27 seems like the unit test that you added is failing, could you take a look ? |
|
@scopsy fixed now, have a look |
LetItRock
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What change does this PR introduce?
Novu used an npm packaged called sanitize-html, the default allowed tags, doesnt include img tags, this PR aims to include it as it was done for the style tag in this #4841.
Why was this change needed?
Closes #5310
Other information (Screenshots)