Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(dashboard): Workflow list polish #6645

Merged
merged 14 commits into from
Oct 9, 2024
Merged

feat(dashboard): Workflow list polish #6645

merged 14 commits into from
Oct 9, 2024

Conversation

desiprisg
Copy link
Contributor

@desiprisg desiprisg commented Oct 7, 2024 •
edited
Loading

What changed? Why was the change needed?

  • Loading state skeletons
  • Fill up remaining screen height
  • Pagination corresponding to correct API data
  • show tooltip on name hover when there is not enough space
  • differentiate code-first workflows with the corresponding icon
  • Add status badge from API

Screenshots

image

Expand for optional sections

Related enterprise PR

Special notes for your reviewer

@desiprisg desiprisg self-assigned this Oct 7, 2024
@desiprisg desiprisg changed the title Workflow list polish feat(dashboard): Workflow list polish Oct 7, 2024
@netlify Netlify
Copy link

netlify bot commented Oct 7, 2024 •
edited
Loading

✅ Deploy Preview for novu-stg-vite-dashboard-poc ready!

Name Link
🔨 Latest commit 101e3df
🔍 Latest deploy log https://app.netlify.com/sites/novu-stg-vite-dashboard-poc/deploys/6706725c3cdefa000861a8e4
😎 Deploy Preview https://deploy-preview-6645--novu-stg-vite-dashboard-poc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@desiprisg desiprisg force-pushed the workflow_list_polish branch from 567bf2c to 23aa145 Compare October 7, 2024 22:48
@desiprisg desiprisg force-pushed the workflow_list_polish branch from 60751eb to 577e9f3 Compare October 8, 2024 11:03
@desiprisg desiprisg force-pushed the workflow_list_polish branch from d694949 to b2e1f78 Compare October 8, 2024 14:55
@desiprisg desiprisg marked this pull request as ready for review October 8, 2024 15:03
@desiprisg desiprisg requested a review from LetItRock October 8, 2024 16:11
desiprisg added 14 commits October 9, 2024 15:08
@desiprisg
feat(dashboard): Default font
ef4a28d
@desiprisg
feat(dashbord): Make workflow list take up remaining height
352b657
@desiprisg
feat(dashboard): Workflow list loading state
c89ed98
@desiprisg
feat(dashboard): Workflow list pagination and limit
706fc87
@desiprisg
feat(dashboard): Truncated text with tooltip
bf89dd6
@desiprisg
feat(dashboard): Integrate workflow status with API
7de3ac2
@desiprisg
fix(dashbord): Table header font size and step size
a8ee10c
@desiprisg
feat(dashboard): Add code first icon to workflow list items
1684b4e
@desiprisg
fix(dashboard): Pagination with links instead of onClick
628dddf
@desiprisg
fix(dashboard): Disable pagination buttons when necessary
6b15a1a
@desiprisg
fix(dashboard): Hide overflow on table cells
6061917
@desiprisg
chore(dashboard): Abstract default pagination component
0ca58d8
@desiprisg
chore(dashboard): Only keep 12 items per page option on workflow list
c703e1d
@desiprisg
chore(dashboard): Remove primitives route
101e3df
@desiprisg desiprisg force-pushed the workflow_list_polish branch from 2a1b383 to 101e3df Compare October 9, 2024 12:08
@desiprisg desiprisg merged commit 907d3ee into next Oct 9, 2024
31 checks passed
@desiprisg desiprisg deleted the workflow_list_polish branch October 9, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SokratisVidros SokratisVidros SokratisVidros approved these changes

@LetItRock LetItRock LetItRock approved these changes

Assignees

@desiprisg desiprisg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@desiprisg @SokratisVidros @LetItRock