fix(api): fixed deletion + origin bug #6663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for novu-stg-vite-dashboard-poc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
djabarovgeorge
approved these changes
Oct 10, 2024
libs/application-generic/src/usecases/create-workflow/create-workflow.usecase.ts
Outdated
Show resolved
Hide resolved
libs/dal/src/repositories/notification-template/notification-template.schema.ts
Outdated
Show resolved
Hide resolved
| @@ -74,13 +74,13 @@ export class Sync { | |||
| }); | |||
| } | |||
|
|
|||
| const createdWorkflows = await this.createWorkflows(command, discover.workflows); | |||
| const persistedWorkflowsInBridge = await this.createWorkflows(command, discover.workflows); | |||
There was a problem hiding this comment.
I am not sure if the term makes sense as it is persisted both in the bridge and novu database, in this context it is related to the novu database.
There was a problem hiding this comment.
persisted reffers to the database
…orkflow.usecase.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why was the change needed?
had an issue of sync deleting workflows + origin not populating, both resolved.
Screenshots
Expand for optional sections
Related enterprise PR
Special notes for your reviewer