fix(application-generic): handle lock acquisition conflicts #6733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rifont
commented
Oct 21, 2024
| throw new Error(`Failed to acquire lock for key: ${cacheKey}`); | ||
| throw new ConflictException( | ||
| `Failed to acquire cache lock. Please try again later.`, | ||
| ); |
There was a problem hiding this comment.
It was a mistake to include cacheKey in the log as it can expose server implementation details. We just return a simple error message. Note, it's still not ideal that cache issues should throw a client error.
ChmaraX
approved these changes
Oct 21, 2024
✅ Deploy Preview for novu-stg-vite-dashboard-poc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why was the change needed?
409 Conflict Errorwhen a cache lock cannot be acquired.409is commonly understood to be a retryable 4xx error, so this change is semantic.Screenshots
Expand for optional sections
Related enterprise PR
Special notes for your reviewer