Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(web, dashboard): Remove additional quotes in PHP code snippet #6938

Merged

Conversation

rifont
Copy link
Collaborator

@rifont rifont commented Nov 11, 2024

What changed? Why was the change needed?

  • Remove additional quotes in PHP code snippet

Screenshots

BEFORE - extra quotes shown in payload and subscriber object
image

AFTER - No extra quotes present in payload and subscriber object
image

Expand for optional sections

Related enterprise PR

Special notes for your reviewer

closes #6748

Copy link

linear bot commented Nov 11, 2024

@rifont rifont merged commit 344c044 into next Nov 11, 2024
36 checks passed
@rifont rifont deleted the nv-4527-bug-report-incorrect-code-for-php-email-trigger branch November 11, 2024 15:50
Copy link

netlify bot commented Nov 11, 2024

Deploy Preview for novu-stg-vite-dashboard-poc ready!

Name Link
🔨 Latest commit 8e7320e
🔍 Latest deploy log https://app.netlify.com/sites/novu-stg-vite-dashboard-poc/deploys/67321be2e6b71a0008d8df70
😎 Deploy Preview https://deploy-preview-6938--novu-stg-vite-dashboard-poc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Bug Report: Incorrect Code for php email trigger
2 participants