fix(dashboard): Workflow saving status on toast and multiple toasts #6972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for novu-stg-vite-dashboard-poc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
SokratisVidros
approved these changes
Nov 12, 2024
SokratisVidros
approved these changes
Nov 12, 2024
LetItRock
reviewed
Nov 12, 2024
| onSuccess, | ||
| onError, | ||
| export const useUpdateWorkflow = ( | ||
| options?: UseMutationOptions<WorkflowResponseDto, unknown, Parameters<typeof updateWorkflow>[0]> |
There was a problem hiding this comment.
IMO we should not expose the react-query options as we will be tied by it's interface, but rather expose ours with the needed functionality.
There was a problem hiding this comment.
Ideally, I wouldn't create a useUpdateWorkflow hook in general. If we create one hook per mutation/query, we are already tied by its interface. I don't see any difference.
There was a problem hiding this comment.
the difference is that we will be free to change the implementation of the hook to whatever we want if we decide
LetItRock
approved these changes
Nov 12, 2024
desiprisg
force-pushed
the
nv-4644-auto-save-icon-is-confusing
branch
from
31b303c to
789d8c9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why was the change needed?
Screenshots
Screen.Recording.2024-11-12.at.5.46.53.PM.mov
Expand for optional sections
Related enterprise PR
Special notes for your reviewer