fix(dashboard): don't use defaultValues for async content #7187
Conversation
| defaultValues, | ||
| values: { | ||
| ...defaultValues, | ||
| ...step.controls.values, |
There was a problem hiding this comment.
According to some posts values should be used for values that depend on async return and defaultValues on static fields, but the react-hook-form docs states various other things, quite confusing.
There was a problem hiding this comment.
TBH I am not sure I understand the fix. If it works it works but I suggest adding a comment in the code.
✅ Deploy Preview for dev-web-novu ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for novu-stg-vite-dashboard-poc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for dashboard-v2-novu-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| defaultValues, | ||
| values: { | ||
| ...defaultValues, | ||
| ...step.controls.values, |
There was a problem hiding this comment.
TBH I am not sure I understand the fix. If it works it works but I suggest adding a comment in the code.
ChmaraX
deleted the
nv-4941-step-form-values-are-not-being-properly-updated-after
branch
What changed? Why was the change needed?
Details: https://linear.app/novu/issue/NV-4941/step-form-values-are-not-being-properly-updated-after-revisiting
form_fields_bug.mp4