Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ignore EACCES on linking #121

Merged
merged 2 commits into from
May 24, 2024

Conversation

antongolub
Copy link
Contributor

Alternative approach for bypassing EACCES errors on CI.

relates #119

@antongolub antongolub requested a review from a team as a code owner May 23, 2024 18:49
@wraithgar
Copy link
Member

wraithgar commented May 24, 2024

If you are comfortable with rebasing and editing commits, could you isolate the proc-log addition to package.json into a discrete commit that has a deps: prefix?

If you use npm install proc-log you won't have to worry about sorting, npm will do that automatically.

If you aren't, no problem. We can generate a new PR based off of this one for you. Ideally we'll have two commits in the PR, the feat: and the deps:.

Copy link
Contributor

@reggi reggi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for working on this!

@reggi reggi merged commit 9648a7d into npm:main May 24, 2024
21 checks passed
@github-actions github-actions bot mentioned this pull request May 24, 2024
reggi pushed a commit that referenced this pull request Sep 26, 2024
🤖 I have created a release *beep* *boop*
---


## [5.0.0](v4.0.4...v5.0.0)
(2024-09-25)
### ⚠️ BREAKING CHANGES
* `bin-links` now supports node `^18.17.0 || >=20.5.0`
### Features
*
[`9648a7d`](9648a7d)
[#121](#121) ignore EACCES on
linking (@antongolub)
### Bug Fixes
*
[`013be50`](013be50)
[#139](#139) align to npm 10 node
engine range (@reggi)
### Dependencies
*
[`a08d09b`](a08d09b)
[#139](#139)
`[email protected]`
*
[`7d90298`](7d90298)
[#139](#139) `[email protected]`
*
[`0c915a3`](0c915a3)
[#139](#139) `[email protected]`
*
[`502417c`](502417c)
[#139](#139)
`[email protected]`
*
[`722452a`](722452a)
[#139](#139) `[email protected]`
*
[`af7e347`](af7e347)
[#121](#121) add proc-log
### Chores
*
[`463c32f`](463c32f)
[#139](#139) run template-oss-apply
(@reggi)
*
[`ba52600`](ba52600)
[#133](#133) bump
@npmcli/eslint-config from 4.0.5 to 5.0.0 (@dependabot[bot])
*
[`fdf22ae`](fdf22ae)
[#134](#134) postinstall for
dependabot template-oss PR (@hashtagchris)
*
[`d949f7d`](d949f7d)
[#134](#134) bump
@npmcli/template-oss from 4.23.1 to 4.23.3 (@dependabot[bot])

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants