Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Survey URL Accessibility #8

Closed
ardhitoutomo opened this issue Jan 31, 2019 · 2 comments
Closed

Survey URL Accessibility #8

ardhitoutomo opened this issue Jan 31, 2019 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@ardhitoutomo
Copy link

image
image
It looks like almost all survey from the past workshop is still accessible. I'm not sure it's everything because we already had 142 workshops, hence 142 surveys, but the number stop at 130 and once I access survey/131 it takes me back to the index page and returns this
image

@ardhitoutomo ardhitoutomo changed the title Survey URL Accessibility [Bug] Survey URL Accessibility Jan 31, 2019
@onlyphantom onlyphantom added the bug Something isn't working label Feb 1, 2019
@onlyphantom onlyphantom changed the title [Bug] Survey URL Accessibility Survey URL Accessibility Feb 1, 2019
@onlyphantom
Copy link
Owner

I've implemented a simple expiry system so survey forms for past workshops beyond certain duration (currently: 10 days) will no longer be accessible. I know it may not be the most elegant or robust - but for our business use-case this suffice.

Post the Alpha version release, I may consider changing the database models to implement a certain "survey open" check. This adds more process on the administrative side to be sure, but it make sure participants can rate a workshop only when (survey.open == True) and will not be able to access the survey form otherwise. Then our general affairs team need to manually turn survey open / closed - which I'm not very keen on :/

To me: practicality and less-process is preferable. If there's any ideas - please propose and maybe we can consider after the Alpha version release. For now the expiry system works 😃

@onlyphantom onlyphantom reopened this Feb 3, 2019
@onlyphantom onlyphantom self-assigned this Feb 3, 2019
@onlyphantom
Copy link
Owner

  • Pushing to production version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants