This repository was archived by the owner on Oct 27, 2022. It is now read-only.
fix udev pattern to match all the nvme devices #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b-dean
force-pushed
the
fix-udev-pattern
branch
2 times, most recently
from
6067361 to
b49ea9f
Compare
the pattern before said `nvme[0-26]n1` which would only match * nvme0n1 * nvme1n1 * nvme2n1 * nvme6n1 the range is not zero to twenty-six, it is 0 to 2 and also 6 I think that `[0-9]*` is better. because it'll get any number of digits
b-dean
force-pushed
the
fix-udev-pattern
branch
from
b49ea9f to
2d14a25
Compare
oogali
approved these changes
Apr 26, 2020
b-dean
added a commit
to b-dean/ebs-automatic-nvme-mapping
that referenced
this pull request
Feb 9, 2021
b-dean
added a commit
to b-dean/ebs-automatic-nvme-mapping
that referenced
this pull request
Feb 9, 2021
b-dean
added a commit
to b-dean/ebs-automatic-nvme-mapping
that referenced
this pull request
Feb 9, 2021
b-dean
added a commit
to b-dean/ebs-automatic-nvme-mapping
that referenced
this pull request
Feb 9, 2021
also fix paths in `ebs-nvme-mapping.sh` this had previously been fixed in oogali#3 but it was changed before it was merged. then I tried to fix it again in oogali#8 but missed some of the digits rebased on top of @pforman-zymergen's PR oogali#13 because I want that binary check but udev needs the full paths
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the pattern before said
nvme[0-26]n1which would only matchthe range is not zero to twenty-six, it is 0 to 2 and also 6
I think that
[0-9][0-9]*is better. because it'll get any one or two digit devices