New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate user provided Histogram bounds at sdk during Instrument creation time #2286

Closed

cijothomas opened this issue Nov 7, 2024 · 0 comments · Fixed by #2351

Assignees

Milestone

Member

cijothomas commented Nov 7, 2024

https://github.com/open-telemetry/opentelemetry-rust/blob/main/opentelemetry-sdk/src/metrics/meter.rs#L385 is only validating name,unit etc. We should validate the buckets at this point, and if validation fails, we should either

Return no-op instrument as do when other validation fails.
Use default bounds, and ignore the user-provided one.

Emit WARN internal log in either case.

cijothomas mentioned this issue

Histogram implementation cleanup #2283

Merged

4 tasks

cijothomas added this to the 0.27.1 milestone

cijothomas self-assigned this

cijothomas mentioned this issue

Bugfix - add validation for custom buckets provided for Histograms #2351

Merged

cijothomas closed this as completed in #2351

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment