Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix - add validation for custom buckets provided for Histograms #2351

Merged
merged 12 commits into from
Nov 27, 2024

Conversation

cijothomas
Copy link
Member

Fixes #2286

@cijothomas cijothomas requested a review from a team as a code owner November 26, 2024 21:51
Copy link

codecov bot commented Nov 26, 2024

Codecov Report

Attention: Patch coverage is 91.83673% with 4 lines in your changes missing coverage. Please review.

Project coverage is 79.5%. Comparing base (fa6e6cd) to head (c55370d).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
opentelemetry-sdk/src/metrics/meter.rs 84.6% 4 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main   #2351   +/-   ##
=====================================
  Coverage   79.5%   79.5%           
=====================================
  Files        123     123           
  Lines      21395   21443   +48     
=====================================
+ Hits       17010   17054   +44     
- Misses      4385    4389    +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

cijothomas and others added 2 commits November 26, 2024 17:13
@cijothomas cijothomas merged commit 0e221c1 into open-telemetry:main Nov 27, 2024
22 of 23 checks passed
@cijothomas cijothomas deleted the cijothomas/fix2286 branch November 27, 2024 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Validate user provided Histogram bounds at sdk during Instrument creation time
3 participants