-
Notifications
You must be signed in to change notification settings - Fork 502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix - add validation for custom buckets provided for Histograms #2351
Merged
cijothomas
merged 12 commits into
open-telemetry:main
from
cijothomas:cijothomas/fix2286
Nov 27, 2024
Merged
Bugfix - add validation for custom buckets provided for Histograms #2351
cijothomas
merged 12 commits into
open-telemetry:main
from
cijothomas:cijothomas/fix2286
Nov 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2351 +/- ##
=====================================
Coverage 79.5% 79.5%
=====================================
Files 123 123
Lines 21395 21443 +48
=====================================
+ Hits 17010 17054 +44
- Misses 4385 4389 +4 ☔ View full report in Codecov by Sentry. |
lalitb
approved these changes
Nov 26, 2024
utpilla
reviewed
Nov 27, 2024
utpilla
reviewed
Nov 27, 2024
utpilla
reviewed
Nov 27, 2024
utpilla
reviewed
Nov 27, 2024
utpilla
reviewed
Nov 27, 2024
utpilla
reviewed
Nov 27, 2024
utpilla
reviewed
Nov 27, 2024
Co-authored-by: Utkarsh Umesan Pillai <[email protected]>
Co-authored-by: Utkarsh Umesan Pillai <[email protected]>
utpilla
approved these changes
Nov 27, 2024
utpilla
reviewed
Nov 27, 2024
This was referenced Nov 27, 2024
pitoniak32
pushed a commit
to pitoniak32/opentelemetry-rust
that referenced
this pull request
Dec 4, 2024
…pen-telemetry#2351) Co-authored-by: Utkarsh Umesan Pillai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2286