Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename HTTPText to TextMap Propagator #192

Merged
merged 9 commits into from
Aug 25, 2020
Merged

Rename HTTPText to TextMap Propagator #192

merged 9 commits into from
Aug 25, 2020

Conversation

craigpastro
Copy link
Contributor

I guess examples/tracing-grpc is constrained by tracing-opentelemetry so couldn't be updated atm.

Closes #184.

@craigpastro craigpastro requested a review from a team August 23, 2020 04:24
jtescher
jtescher requested changes Aug 23, 2020
View reviewed changes
Copy link
Member

@jtescher jtescher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one request

jtescher
jtescher requested changes Aug 24, 2020
View reviewed changes
jtescher
jtescher approved these changes Aug 25, 2020
View reviewed changes
Copy link
Member

@jtescher jtescher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks @siyopao

@jtescher jtescher merged commit 6560aea into open-telemetry:master Aug 25, 2020
@craigpastro craigpastro deleted the rename-to-textmap branch August 25, 2020 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtescher jtescher jtescher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename HTTPText to TextMap Propagator.
2 participants
@craigpastro @jtescher