Propagate valid span context in noop tracer #197
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the API to propagate valid span contexts if no SDK tracer is configured and new spans are created.
Part of #181
Description
The latest specification reads:
If I understand it correctly, this maps to the
NoopTracer
in this repo. Currently theNoopTracer
always creates invalid spans.I copied the logic from the
sdk::Tracer
about figuring out the correct parent span context. If this is correct, we could consider moving this logic into a function shared between theNoopTracer
and thesdk::Tracer
.