Add end_with_timestamp method for trace span. #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtescher
requested changes
Aug 27, 2020
src/api/trace/span.rs
Outdated
| @@ -152,8 +152,15 @@ pub trait Span: fmt::Debug + 'static + Send + Sync { | |||
| /// Calls to `end` a Span MUST not have any effects on child `Span`s as they may | |||
| /// still be running and can be ended later. | |||
| /// | |||
| ///This API MUST be non-blocking. | |||
| /// This API MUST be non-blocking. | |||
| fn end(&self); | |||
There was a problem hiding this comment.
It may be useful to implement this method by default in terms of end_with_timestamp now to avoid requiring redundant impls for both methods.
* Add default implementation for `end`.
|
@TommyCpp looks like the clippy rules got updated today so this is no longer passing 😐 |
That's interesting. I will update it later today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #14
On a side note, maybe we could create a mod for test utils. We have
TestSpanin four different files, which could be put into one place.