Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AWS X-Ray ID Generator #201

Merged
merged 1 commit into from
Aug 29, 2020

Conversation

awiede
Copy link

@awiede awiede commented Aug 29, 2020

Adds an ID Generator that builds traces in a format that can be backed out into an AWS X-Ray compliant trace-id by the OTel collector. Logic follows the inverse of the convertToAmazonTraceID method in the AWS X-Ray exporter in the OTel collector. Will submit a separate PR for the X-Ray propagator to convert between OTel format and X-Ray formatted trace-id's.

Add ID Generator that builds traces in a format that can be backed out
into an AWS X-Ray compliant trace-id by the OTel collector.
@awiede awiede requested a review from a team August 29, 2020 15:19
@awiede awiede changed the title Add X-Ray ID Generator Add AWS X-Ray ID Generator Aug 29, 2020
Copy link
Member

@jtescher jtescher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice to see AWS support coming along

@jtescher jtescher merged commit 6768e26 into open-telemetry:master Aug 29, 2020
@awiede awiede deleted the feature/xray-id-generator branch August 29, 2020 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants