AWS X-Ray Trace Context Propagator #202
Conversation
Create Trace Context Propagator for AWS X-Ray. Collect Root TraceId, Parent SegmentId and Sampling decision in new SpanContext. Additional metadata fields are collected but not yet used since there isn't any way to pass them through SpanContext yet.
awiede
force-pushed
the
feature/xray-propagator
branch
from
ae233da to
286a2f1
Compare
| _private: (), | ||
| } | ||
|
|
||
| impl XrayTraceContextPropagator { |
There was a problem hiding this comment.
Probably best to have a new method
| if span_context.is_valid() { | ||
| let xray_trace_id: XrayTraceId = span_context.trace_id().into(); | ||
| let mut components: Vec<String> = | ||
| vec![format!("{}={}", HEADER_ROOT_KEY, xray_trace_id.0)]; |
There was a problem hiding this comment.
Could probably use vec![...; 3] to avoid possible reallocation
There was a problem hiding this comment.
So specifying vec![...; 3] put in three copies of the first element, refactored to use Vec::with_capacity instead.
There was a problem hiding this comment.
As the formatted string is always the same, you could do one allocation injector.set(AWS_XRAY_TRACE_HEADER, format!("{}={};{}={};{}={}")) to do one string allocation rather than 4 strings and a vec?
There was a problem hiding this comment.
Good call @jtescher, updated. Originally I had this iterating through all k/v pairs to handle arbitrary key/value pairs in the header. The X-Ray SDK lets you pass any additional k/v pairs through, but there isn't a way to capture anything other than traceId, parent ID, and decision in the current SpanContext I don't think? Is that part of the thought with #195?
There was a problem hiding this comment.
Yep #195 should get support for that.
|
Thanks for the 👀 @TommyCpp! Made the suggested updates |
awiede
force-pushed
the
feature/xray-propagator
branch
from
61f1959 to
7308af3
Compare
* Update component vector to initialize with capacity of 3 * Create a "new" method for XrayTraceContextPropagator. * Use SpanId.to_hex() to build hex ID
awiede
force-pushed
the
feature/xray-propagator
branch
from
7308af3 to
d88506c
Compare
Create Trace Context Propagator for AWS X-Ray. Collect Root TraceId, Parent SegmentId and Sampling decision in new SpanContext. Will add to
/exampleslater.