Rename Provider to TracerProvider #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename Provider to TracerProvider.
jtescher
requested changes
Sep 1, 2020
opentelemetry-jaeger/src/lib.rs
Outdated
| @@ -312,11 +312,11 @@ impl PipelineBuilder { | |||
| } | |||
|
|
|||
| /// Build a configured `sdk::Provider` with the recommended defaults. | |||
There was a problem hiding this comment.
May way to find all for stray comments like this one
TommyCpp
requested changes
Sep 1, 2020
src/sdk/trace/provider.rs
Outdated
| @@ -61,7 +61,7 @@ impl Provider { | |||
| } | |||
| } | |||
|
|
|||
| impl api::Provider for Provider { | |||
| impl api::TracerProvider for TracerProvider { | |||
| /// This implementation of `api::Provider` produces `sdk::Tracer` instances. | |||
There was a problem hiding this comment.
Suggested change
| /// This implementation of `api::Provider` produces `sdk::Tracer` instances. | |
| /// This implementation of `api::TraceProvider` produces `sdk::Tracer` instances. |
Co-authored-by: Zhongyang Wu <[email protected]>
awiede
force-pushed
the
rename-proivder
branch
from
25660ed to
4de0e55
Compare
jtescher
approved these changes
Sep 2, 2020
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #198
Rename
ProvidertoTracerProviderfor bothapi::Providerandsdk::Provider.