-
Notifications
You must be signed in to change notification settings - Fork 502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TraceState to SpanContext #217
Conversation
Initial creation of TraceState type.
Add tests for TraceState.
Clean up unit tests.
Add trace state to propagators.
Dummy commit.
Clean up base64 test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great start @awiede! added a few ideas for potential allocation improvements
opentelemetry-contrib/src/trace_propagator/aws_xray_propagator.rs
Outdated
Show resolved
Hide resolved
opentelemetry-contrib/src/trace_propagator/jaeger_propagator.rs
Outdated
Show resolved
Hide resolved
opentelemetry-contrib/src/trace_propagator/jaeger_propagator.rs
Outdated
Show resolved
Hide resolved
Address PR comments.
Clean up TraceState to not use a hashmap. Update from_kv method to use iterator.
Export TraceState and add example for from_key_value.
@jtescher - I think I addressed all of your comments. RE: using a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@awiede yeah that makes sense I hadn't read the spec all that closely 😬, looked it over and noticed a few other changes we may want to do
Clean up trace state methods.
Validate keys and values.
Validate inputs on TraceState creation.
Make modification methods `Fn`.
Restrict tracestate keys to lowercase.
@jtescher updated to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good thanks @awiede
Resolves #211
Adds
TraceState
toSpanContext
and givesTraceState
new methods per spec.