Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add few internal logs for Metrics sdks #2350

Merged
merged 3 commits into from
Nov 26, 2024

Conversation

cijothomas
Copy link
Member

Modified self-diag example to not do anything invalid to trigger logs, as we have sufficient logs otherwise to demonstrate!
Also few logs inside Metric sdk.

@cijothomas cijothomas requested a review from a team as a code owner November 26, 2024 20:18
@cijothomas cijothomas added this to the 0.27.1 milestone Nov 26, 2024
Copy link

codecov bot commented Nov 26, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 10 lines in your changes missing coverage. Please review.

Project coverage is 79.5%. Comparing base (91370d2) to head (76f57ff).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
opentelemetry-sdk/src/metrics/meter_provider.rs 53.3% 7 Missing ⚠️
opentelemetry-sdk/src/metrics/pipeline.rs 50.0% 2 Missing ⚠️
opentelemetry-sdk/src/metrics/periodic_reader.rs 0.0% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main   #2350     +/-   ##
=======================================
- Coverage   79.5%   79.5%   -0.1%     
=======================================
  Files        123     123             
  Lines      21366   21379     +13     
=======================================
+ Hits       17000   17001      +1     
- Misses      4366    4378     +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@utpilla utpilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some suggestions.

@utpilla utpilla merged commit 1cecaea into open-telemetry:main Nov 26, 2024
21 of 23 checks passed
@cijothomas cijothomas deleted the cijothomas/internallogs-4 branch November 26, 2024 22:13
pitoniak32 pushed a commit to pitoniak32/opentelemetry-rust that referenced this pull request Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants