Move propagators to sdk::propagation module #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the propagation modules are mixed in a confusing way (e.g. baggage propagator is in api, but trace context is in sdk). This change standardizes the propagator locations by having propagation formats in
api::propagation(only text map currently), keeps global propagation utilities inglobal::propagation, and moves propagator implementations tosdk::propagation.High level changes:
sdk::trace::propagatortosdk::propagationTextMapFormattoTextMapPropagatorto match the spec.TraceContextPropagatorto match the spec and because the baggage propagator is also a w3c propagator.TextMapFormatfrom examples because they should be setting/getting the global so they interact properly with middleware.