Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename SpanContext to SpanReference #270

Merged
merged 4 commits into from
Oct 15, 2020
Merged

Rename SpanContext to SpanReference #270

merged 4 commits into from
Oct 15, 2020

Conversation

drexler
Copy link
Contributor

@drexler drexler commented Oct 15, 2020

Reference issue: #267

@drexler drexler requested a review from a team October 15, 2020 02:35
@drexler
Copy link
Contributor Author

drexler commented Oct 15, 2020

Probably a delayed response but I've already signed the EasyCLA Individual Contributor Agreement

jtescher
jtescher approved these changes Oct 15, 2020
View reviewed changes
Copy link
Member

@jtescher jtescher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good thanks @drexler, if you push a commit I think it will bump the CLA bot 🙄

@drexler
Copy link
Contributor Author

drexler commented Oct 15, 2020

@jtescher Thanks for the review 👍

@jtescher jtescher merged commit cd6c878 into open-telemetry:master Oct 15, 2020
@jtescher jtescher mentioned this pull request Oct 15, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtescher jtescher jtescher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@drexler @jtescher