Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename SpanReference back to SpanContext #299

Merged
merged 2 commits into from
Oct 25, 2020
Merged

Rename SpanReference back to SpanContext #299

merged 2 commits into from
Oct 25, 2020

Conversation

drexler
Copy link
Contributor

@drexler drexler commented Oct 24, 2020

Reference issue: #298

@drexler drexler requested a review from a team October 24, 2020 13:56
@jtescher
Copy link
Member

@drexler looks like there are some conflicts now, otherwise looks ready to merge 👍

@drexler drexler force-pushed the unrename-span-context branch from 65faf70 to ed6cae2 Compare October 24, 2020 20:34
@drexler
Copy link
Contributor Author

drexler commented Oct 24, 2020

@jtescher I've rebased the branch.

@jtescher
Copy link
Member

@drexler thanks, looks good!

@jtescher jtescher merged commit 72ee2e6 into open-telemetry:master Oct 25, 2020
@jtescher jtescher mentioned this pull request Oct 25, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frigus02 frigus02 frigus02 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@drexler @jtescher @frigus02