Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update span status codes to match spec #315

Merged
merged 3 commits into from
Oct 30, 2020
Merged

Update span status codes to match spec #315

merged 3 commits into from
Oct 30, 2020

Conversation

drexler
Copy link
Contributor

@drexler drexler commented Oct 29, 2020

Reference issue: #234

@drexler drexler requested a review from a team October 29, 2020 01:53
jtescher
jtescher requested changes Oct 29, 2020
View reviewed changes
Copy link
Member

@jtescher jtescher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @drexler, just one small request

@drexler drexler force-pushed the status-code-update branch from 1fa5239 to 7b380bf Compare October 29, 2020 23:00
@drexler drexler requested a review from jtescher October 29, 2020 23:47
jtescher
jtescher approved these changes Oct 30, 2020
View reviewed changes
Copy link
Member

@jtescher jtescher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jtescher jtescher merged commit 6edf889 into open-telemetry:master Oct 30, 2020
@jtescher jtescher mentioned this pull request Oct 30, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtescher jtescher jtescher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@drexler @jtescher