Ensure is_recording
is false and all methods are no-ops after span ends
#341
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is targeting to resolve #265. It moves span processing logic from
SpanInner
'sdrop
to a separate method and calling it on end. This method takes ownership of inner.data.span_data sowith_data
always returnsNone
.is_recording
checks inner.data and inner.data.span_data now and returns false if some of this options isNone
. Because of two nested options this check looks kind of ugly 😞