Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure metrics noop types go through constructors #345

Merged
merged 2 commits into from
Nov 6, 2020

Conversation

jtescher
Copy link
Member

@jtescher jtescher commented Nov 5, 2020

No description provided.

@jtescher jtescher requested a review from a team November 5, 2020 20:37
@codecov
Copy link

codecov bot commented Nov 5, 2020

Codecov Report

Merging #345 into master will decrease coverage by 0.13%.
The diff coverage is 17.24%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #345      +/-   ##
==========================================
- Coverage   53.83%   53.69%   -0.14%     
==========================================
  Files          69       69              
  Lines        5770     5790      +20     
==========================================
+ Hits         3106     3109       +3     
- Misses       2664     2681      +17     
Impacted Files Coverage Δ
opentelemetry/src/global/metrics.rs 100.00% <ø> (ø)
opentelemetry/src/api/metrics/noop.rs 20.00% <17.24%> (-2.86%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45b0963...500ceb6. Read the comment docs.

@jtescher jtescher merged commit 03fe982 into master Nov 6, 2020
@jtescher jtescher deleted the metrics-noop-constructors branch November 6, 2020 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants