Change ExportResult to std::result::Result #347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #347 +/- ##
==========================================
+ Coverage 53.69% 53.81% +0.11%
==========================================
Files 69 69
Lines 5790 5779 -11
==========================================
+ Hits 3109 3110 +1
+ Misses 2681 2669 -12
Continue to review full report at Codecov.
|
frigus02
force-pushed
the
update-exportresult
branch
from
b552c7d to
4c03612
Compare
The spec changed and ExportResult no longer includes the hint about error being retriable. Since it now only distinguishes between success and error, it makes sense to use Rust's standard Result type.
frigus02
force-pushed
the
update-exportresult
branch
from
4c03612 to
b221a9d
Compare
|
Also looks like the CLA bot is stuck again.. |
frigus02
force-pushed
the
update-exportresult
branch
from
b221a9d to
5847d14
Compare
|
Hm yeah. How do we get it unstuck? Do we just wait? |
|
Not sure why it stops working, but pushing an empty commit should trigger it (when it starts working again?) |
|
Cool. I push another commit tomorrow 🤞 |
frigus02
force-pushed
the
update-exportresult
branch
from
fb279c7 to
7c1d709
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The spec changed and ExportResult no longer includes the hint about error being retriable. Since it now only distinguishes between success and error, it makes sense to use Rust's standard Result type.
Closes #331