-
Notifications
You must be signed in to change notification settings - Fork 502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement timeout for force_flush and shutdown. #362
Conversation
Note that the spec only has configuration for maximum time to export data. So the timeout is based on the export time.
Note that the spec only has configuration for maximum time to export data. So the timeout is based on the export time.
Codecov Report
@@ Coverage Diff @@
## master #362 +/- ##
==========================================
+ Coverage 54.56% 55.20% +0.64%
==========================================
Files 70 71 +1
Lines 5914 6048 +134
==========================================
+ Hits 3227 3339 +112
- Misses 2687 2709 +22
Continue to review full report at Codecov.
|
* Block force_flush until the export results returned from worker. * Return ExportResult for force_flush and shutdown.
# Conflicts: # opentelemetry/src/sdk/trace/span_processor.rs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like the correct approach to me. I didn't manage to review the tests, yet. Will try to do this later today.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a clippy warning:
casting integer literal to
usize
is unnecessary
Otherwise this looks good to me 👍
Looks like cargo fmt check is failing still |
TraceError
enum, still need to add other error type.Note that the spec only has configuration for maximum time to export data. So the timeout is based on the export time.
Also included the update from otel-proto