Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix remote implicit builder context sampling #405

Merged
merged 1 commit into from
Dec 29, 2020

Conversation

jtescher
Copy link
Member

Fixes #404

@jtescher jtescher requested a review from a team December 29, 2020 21:41
Copy link
Member

@frigus02 frigus02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can confirm that this fixes the issue 👍

@codecov
Copy link

codecov bot commented Dec 29, 2020

Codecov Report

Merging #405 (ceef69b) into master (ddcf8a4) will increase coverage by 0.06%.
The diff coverage is 93.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #405      +/-   ##
==========================================
+ Coverage   49.32%   49.39%   +0.06%     
==========================================
  Files          66       66              
  Lines        5409     5416       +7     
==========================================
+ Hits         2668     2675       +7     
  Misses       2741     2741              
Impacted Files Coverage Δ
opentelemetry/src/sdk/trace/tracer.rs 75.80% <93.33%> (+0.94%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ddcf8a4...ceef69b. Read the comment docs.

@jtescher jtescher merged commit dc924b3 into master Dec 29, 2020
@jtescher jtescher deleted the bugfix/implicit-remote-builder-context branch December 29, 2020 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remote span context is not taken from current context
2 participants