Configure async runtime in Rust code instead of cargo feature #481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djc
reviewed
Mar 15, 2021
frigus02
force-pushed
the
with-runtime
branch
2 times, most recently
from
a01e3bb to
3c9c1d8
Compare
|
Might need an empty commit to nudge the EasyCLA |
|
I'm going to test the examples now to make sure they all still work |
|
Result:
From my side this is ready to be merged. |
Configure the async runtime (Tokio, async-std, ...) in Rust using `with_runtime(runtime)` on the trace pipeline builders instead of using cargo features. The main advantages of using Rust code is that cargo doesn't have a way of describing mutually exclusive features at the moment. We currently fall back to Tokio if multiple runtime features are enabled. This can be confusing, especially if a runtime feature is enabled by another crate. Choosing the runtime in Rust code means the entire trace pipeline configuration is in one place.
- Remove `()` runtime implementation - Replace `install` function with `install_simple` and `install_batch`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #469.
Configure the async runtime (Tokio, async-std, ...) in Rust using
install_batch(runtime)on the trace pipeline builders instead of using cargo features.The main advantages of using Rust code is that cargo doesn't have a way of describing mutually exclusive features at the moment. We currently fall back to Tokio if multiple runtime features are enabled. This can be confusing, especially if a runtime feature is enabled by another crate.
Choosing the runtime in Rust code means the entire trace pipeline configuration is in one place.
With this:
rt-*cargo features can be enabled at the same time. The only downside of enabling more features is a longer build time.Runtimetrait or useinstall_simple()to use the simple span processor.Examples: