fix mapping references in elastic-ecs connector #1471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdazam1942
reviewed
May 9, 2023
stix_shifter_modules/elastic_ecs/stix_translation/json/to_stix_map.json
Outdated
Show resolved
Hide resolved
mdazam1942
reviewed
May 9, 2023
stix_shifter_modules/elastic_ecs/stix_translation/json/to_stix_map.json
Outdated
Show resolved
Hide resolved
mdazam1942
reviewed
May 9, 2023
stix_shifter_modules/elastic_ecs/stix_translation/json/stix_2_1/to_stix_map.json
Outdated
Show resolved
Hide resolved
…tix-shifter into patch-elastic-mapping
…e appropriate ipv4/ipv6 object
…tix-shifter into patch-elastic-mapping
…e appropriate ipv4/ipv6 object
subbyte
reviewed
May 16, 2023
| @@ -1015,8 +1089,8 @@ | |||
| } | |||
| ], | |||
| "ppid": { | |||
| "key": "process.parent_ref.ppid", | |||
There was a problem hiding this comment.
Not sure if we have process:ppid and process:pgid in STIX. May need a double check.
There was a problem hiding this comment.
Both attributes are pid refs. ppid refers to the parent process pid, while pgid refers to the process group leader pid. NB: pgid to be deprecated and referred to as process.group_leader.pid.
Fixed the refs in to_stix_map. See new commit.
A new group_leader_ref reference attribute should be added to Process STIX extensions.
|
Quick check: in |
mdazam1942
approved these changes
May 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes mapping errors identified by the to_stix_map validator.