Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move results processing to transmission results #1519

Merged
merged 12 commits into from
Jul 10, 2023

Conversation

mdazam1942
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Jun 26, 2023

Codecov Report

Patch coverage: 43.82% and project coverage change: -0.11 ⚠️

Comparison is base (c423e5c) 85.43% compared to head (9163c80) 85.32%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1519      +/-   ##
===========================================
- Coverage    85.43%   85.32%   -0.11%     
===========================================
  Files          680      672       -8     
  Lines        54164    54071      -93     
===========================================
- Hits         46273    46136     -137     
- Misses        7891     7935      +44     
Impacted Files Coverage Δ
.../aws_athena/stix_transmission/results_connector.py 77.87% <9.09%> (-7.11%) ⬇️
...fter_modules/reaqta/stix_transmission/connector.py 45.58% <33.33%> (-9.97%) ⬇️
...les/cbcloud/stix_transmission/results_connector.py 56.92% <36.84%> (-28.27%) ⬇️
..._vision_one/stix_transmission/results_connector.py 81.25% <52.63%> (-18.75%) ⬇️
...carbonblack/stix_translation/results_translator.py 100.00% <100.00%> (+5.55%) ⬆️
...es/cbcloud/tests/stix_transmission/test_cbcloud.py 100.00% <100.00%> (ø)
stix_shifter_modules/elastic_ecs/entry_point.py 100.00% <100.00%> (ø)
stix_shifter_modules/infoblox/entry_point.py 100.00% <100.00%> (ø)
.../test/stix_translation/test_reaqta_json_to_stix.py 99.49% <100.00%> (ø)
...ules/splunk/stix_transmission/results_connector.py 82.58% <100.00%> (+0.58%) ⬆️
... and 1 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mdazam1942 mdazam1942 force-pushed the results_translator_update branch from 0211c49 to dbad2b6 Compare July 6, 2023 15:32
@mdazam1942 mdazam1942 marked this pull request as ready for review July 6, 2023 19:07
@mdazam1942 mdazam1942 requested a review from delliott90 July 6, 2023 19:07
@delliott90
Copy link
Collaborator

If all the results_translators are being removed, shouldn't it's reference also be removed from the base entry point? https://github.com/opencybersecurityalliance/stix-shifter/blob/develop/stix_shifter_utils/utils/base_entry_point.py#L126

@delliott90
Copy link
Collaborator

You will likely want to remove the results_translator from the various template projects.

@mdazam1942 mdazam1942 force-pushed the results_translator_update branch from 95db43d to 7626e8b Compare July 7, 2023 17:09
@mdazam1942 mdazam1942 force-pushed the results_translator_update branch from 9291aaf to 45d603d Compare July 10, 2023 17:59
@mdazam1942 mdazam1942 merged commit eab6c5b into develop Jul 10, 2023
@mdazam1942 mdazam1942 deleted the results_translator_update branch July 10, 2023 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants